-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added reversals #250
Merged
Merged
added reversals #250
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
58862a3
added reversals
ankitdas13 2c133fc
Merge branch 'master' into update_transfer
ankitdas13 d92aaff
added failure test case
ankitdas13 01c60f5
updated fixtures
ankitdas13 3eaf6ba
removed chaining
ankitdas13 6c93e6e
Merge branch 'master' into update_transfer
ankitdas13 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
{ | ||
"entity":"collection", | ||
"count":1, | ||
"items":[ | ||
{ | ||
"id":"rvrsl_Lt09xvyzskI7KZ", | ||
"entity":"reversal", | ||
"transfer_id":"trf_Lt048W7cgLdo1u", | ||
"amount":50000, | ||
"fee":0, | ||
"tax":0, | ||
"currency":"INR", | ||
"notes":[ | ||
|
||
], | ||
"initiator_id":"Ghri4beeOuMTAb", | ||
"customer_refund_id":null, | ||
"utr":null, | ||
"created_at":1684822489 | ||
} | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||
---|---|---|---|---|
|
@@ -73,5 +73,12 @@ def test_transfer_direct_transfer | |||
assert_equal transfer.id, @transfer_id , 'Transfer transfer_id is accessible' | ||||
refute transfer.on_hold | ||||
end | ||||
|
||||
def test_fetch_reversals | ||||
stub_get(%r{/transfers/#{@transfer_id}/reversals$}, 'reversals_collection') | ||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. please add test case for 5xx response. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added test cases
|
||||
transfer = Razorpay::Transfer.fetch(@transfer_id).reversals | ||||
assert_instance_of Razorpay::Collection, transfer , 'Transfer should be an array' | ||||
refute_empty transfer.items , 'Transfer should be more than one' | ||||
end | ||||
end | ||||
end |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove the method chaining
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed chaining , also updated in doc and unit test
razorpay-ruby/lib/razorpay/transfer.rb
Line 35 in 3eaf6ba