Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Makefile cleanups #10

Merged
merged 1 commit into from
Jan 11, 2024
Merged

chore: Makefile cleanups #10

merged 1 commit into from
Jan 11, 2024

Conversation

smoser
Copy link

@smoser smoser commented Jan 11, 2024

Clean up makefile for:

  • modify PATH with export to point at TOOLS_D/bin this way when test or any target is executed, the tools are in the path.
  • drop export of SKOPEO , just use it by name in test/.
  • Do not export BATS, it was never used anywhere
  • test targets do not need LXC_BRANCH or LXC_CLONE_URL
  • docker-clone depends on skopeo (tools/oci-copy uses it)

Clean up makefile for:
 * modify PATH with export to point at TOOLS_D/bin
   this way when test or any target is executed, the tools are in the
   path.
 * drop export of SKOPEO , just use it by name in test/.
 * Do not export BATS, it was never used anywhere
 * test targets do not need LXC_BRANCH or LXC_CLONE_URL
 * docker-clone depends on skopeo (tools/oci-copy uses it)

Signed-off-by: Scott Moser <[email protected]>
@smoser smoser requested a review from rchincha as a code owner January 11, 2024 19:19
@rchincha rchincha merged commit d89be32 into rchincha:deps Jan 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants