Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid commit suffixes on release tags #37

Merged
merged 2 commits into from
Oct 30, 2024
Merged

fix: avoid commit suffixes on release tags #37

merged 2 commits into from
Oct 30, 2024

Conversation

rcwbr
Copy link
Owner

@rcwbr rcwbr commented Oct 30, 2024

Closes #36

What

Override GitHub-provided ref protected variable to correct the image ref format for tag workflows

Why

The provided variable is never true for tags, even if protected, resulting in image refs with commit SHAs (e.g. the 0.1.1 image)

How

Override the GITHUB_REF_PROTECTED variable

@rcwbr rcwbr added the bug Something isn't working label Oct 30, 2024
@rcwbr rcwbr self-assigned this Oct 30, 2024
@rcwbr rcwbr linked an issue Oct 30, 2024 that may be closed by this pull request
Tag workflows produce images ref commit suffixes #36
Closed
@rcwbr rcwbr force-pushed the 36-tag-workflows-produce-images-ref-commit-suffixes branch from 673a2a1 to faafe4d Compare October 30, 2024 02:32
@rcwbr rcwbr merged commit b8f554a into main Oct 30, 2024
9 checks passed
@rcwbr rcwbr deleted the 36-tag-workflows-produce-images-ref-commit-suffixes branch October 30, 2024 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rcwbr rcwbr

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tag workflows produce images ref commit suffixes
1 participant
@rcwbr