Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

highlight_area() #20

Merged
merged 6 commits into from
Apr 10, 2023
Merged

highlight_area() #20

merged 6 commits into from
Apr 10, 2023

Conversation

Moosems
Copy link
Collaborator

@Moosems Moosems commented Apr 10, 2023

Fixes #19, #16

test:

from chlorophyll import CodeView
from tkinter import Tk

root = Tk()
codeview = CodeView(root)
codeview.pack()

for i in range(100):
    codeview.insert("end", "print()\n")

codeview.hightlight_area(1, 100)
root.mainloop()

@Moosems Moosems requested a review from rdbende April 10, 2023 20:30
@Moosems Moosems changed the title First commit highlight_area() Apr 10, 2023
chlorophyll/codeview.py Outdated Show resolved Hide resolved
Copy link
Owner

@rdbende rdbende left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM mostly

@Moosems Moosems requested a review from rdbende April 10, 2023 20:41
chlorophyll/codeview.py Outdated Show resolved Hide resolved
chlorophyll/codeview.py Outdated Show resolved Hide resolved
Moosems and others added 2 commits April 10, 2023 16:48
Lol

Co-authored-by: rdbende <[email protected]>
@Moosems
Copy link
Collaborator Author

Moosems commented Apr 10, 2023

New test:

from chlorophyll import CodeView
from tkinter import Tk
from pygments.lexers import PythonLexer

root = Tk()
codeview = CodeView(root, lexer=PythonLexer)
codeview.pack()

for i in range(100):
    codeview.insert("end", "print()\n")
codeview.insert("50.0", "\"\"\"\ntest\n\"\"\"\n")
codeview.highlight_area(25, 75)
root.mainloop()

@Moosems Moosems requested a review from rdbende April 10, 2023 21:00
chlorophyll/codeview.py Outdated Show resolved Hide resolved
Moosems and others added 2 commits April 10, 2023 17:05
Co-authored-by: rdbende <[email protected]>
@Moosems
Copy link
Collaborator Author

Moosems commented Apr 10, 2023

Black and Isort came up empty. Looks good to me, you approve?

@rdbende rdbende merged commit 7255c3c into main Apr 10, 2023
@Moosems Moosems deleted the highlight_area branch April 10, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New tklinenums 1.6.2 removes need to pass font
2 participants