Fix py_minor_version
check in setup.py
#241
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for bug introduced in #240
The
in
operator preceded the walrus operator resulting in the comparison beingTrue >= 10
and still pinning the Django version to <5 regardless of python version. The parentheses added fix this problem, and I used theminor
attribute instead of index for readability.The build didn't catch this because the installation of django-twilio came after the installation of django at the specified version, which was uninstalling django and reinstalling a compatible version. I rearranged the build so that this problem is demonstrated when it occurs.