-
Notifications
You must be signed in to change notification settings - Fork 4
Don't leak the injector instance into the class. #14
Conversation
Prior to this change, We need another way to allow access to the injector in this case. Here are some ideas:
My preference is for 3. It might seem radical, but I really don't think it is. |
Thanks for this. We can go with 3 given how subinjectors work. |
I'll come up with a patch. |
I see the docs need to be updated. I'm working on that now. |
So now we don't support |
Yes. |
I've merely omitted any discussion of Should we document the deprecation or add something like this? if not provide_self:
warnings.warn(DeprecationWarning('provide_self=False is not supported')) |
|
I noticed this while scratching my
Injector.alias()
itch (#13).