-
Notifications
You must be signed in to change notification settings - Fork 120
fix #34 #36
fix #34 #36
Conversation
using esm to load |
potentially esm could be used in every script that might exhibit similar issues. |
I might squash these 2 if everything's ok. |
uncommented out babel-config typescript plugins, uncommented extract-intl, added module loader for ES5 exports
9df37a8
to
0e5b898
Compare
Can you explain shortly how I also disabled babel typescript plugin because firstly it isnt used. Any specific reason to bring it back ? |
Oh, sorry, I just uncommented all code in babel without looking through it, I though you did it just to get rid of an error. Perhaps, make a new PR to remove
|
ok. i udnerstand. This version is fine. Just wanted to understand the reason behind esm module. I ll merge this. But can you commit back the commented-out babel plugin codes. Or you can remove babel plugin typescript entirely. It doesnt support namespaces and in my opinion not ready as ts-loader. |
done |
uncommented out babel-config typescript plugins,
uncommented extract-intl,
changed ES5 export to module.exports
extract-intl generates translation with no errors:

translation messages seemingly unchanged after running generation