Skip to content
This repository was archived by the owner on Sep 6, 2022. It is now read-only.

change target to es5, closes #51 #52

Merged
merged 1 commit into from
Oct 27, 2019

Conversation

GrayStrider
Copy link
Contributor

typecheck ✔️
tests ✔️

@Can-Sahin
Copy link
Member

hmm I dont remember why but when I initially started this repo I was making it es5. There might be a some problem. Only think I can think of is the #4 issue.

Can you validate the code splitting working with es5 with dynamic imports.

@GrayStrider
Copy link
Contributor Author

image
Running GrayStrider:patch-es5, I assume that is the intended behaviour?

@GrayStrider
Copy link
Contributor Author

If the comment here is to be believed, some comments in the referred issue as well, code splitting problem was due to "module" part of the config, so unrelated.
image

@Can-Sahin Can-Sahin merged commit b17c2be into react-boilerplate:master Oct 27, 2019
@GrayStrider GrayStrider deleted the patch-es5 branch October 27, 2019 23:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants