This repository was archived by the owner on Sep 6, 2022. It is now read-only.
React Boilerplate Typescript v4.1 #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `path` argument of `fs.readFileSync` is relative to the working directory, so linting in Atom was broken for mono-repos (as eslint is not executed from the project root).
Spelling mistake fix in docs
…… (#2290) * [Fix] Fixing issue where apple-touch-icon meta tags are pointing to non-existing sources as they were not generated by Webpack * Adding the 'inject' property to make clear that HTML injection is on
Just a quick update of the docs-- seems IntlProvider was changed to LanguageProvider.
Babel 7 was recently released so I gave a shot at upgrading it. Followed the advice from the official upgrade guide [here](https://babeljs.io/docs/en/v7-migration). Also, stage presets were removed so I used [babel-upgrade](https://github.com/babel/babel-upgrade) to make sure we had the relevant plugins for stage 0 (as we had until now).
…ss's state name (#2325)
…… (#2328) feat(ci): change node versions to use Current and LTS
Return to npm! Updated docs, CI pipelines and setup script as well.
Some docs refer to removing an eslint exception that doesn't exist
👋 I don't think there's an issue for this or that one would be warranted. Happy to open one if that's preferred. The links to VS Code docs were outdated and there was a small typo so fixed it along the way. ## React Boilerplate Thank you for contributing! Please take a moment to review our [**contributing guidelines**](https://github.com/react-boilerplate/react-boilerplate/blob/master/.github/CONTRIBUTING.md) to make the process easy and effective for everyone involved. **Please open an issue** before embarking on any significant pull request, especially those that add a new library or change existing tests, otherwise you risk spending a lot of time working on something that might not end up being merged into the project. Before opening a pull request, please ensure: - [x] You have followed our [**contributing guidelines**](https://github.com/react-boilerplate/react-boilerplate/blob/master/.github/CONTRIBUTING.md) - [x] double-check your branch is based on `dev` and targets `dev` - [x] Pull request has tests (we are going for 100% coverage!) - [x] Code is well-commented, linted and follows project conventions - [x] Documentation is updated (if necessary) - [x] Internal code generators and templates are updated (if necessary) - [x] Description explains the issue/use-case resolved and auto-closes related issues Be kind to code reviewers, please try to keep pull requests as small and focused as possible :) **IMPORTANT**: By submitting a patch, you agree to allow the project owners to license your work under the terms of the [MIT License](https://github.com/react-boilerplate/react-boilerplate/blob/master/LICENSE.md).
npm start does not start ngrok tunnel. PR to update docs accordingly ## React Boilerplate Thank you for contributing! Please take a moment to review our [**contributing guidelines**](https://github.com/react-boilerplate/react-boilerplate/blob/master/.github/CONTRIBUTING.md) to make the process easy and effective for everyone involved. **Please open an issue** before embarking on any significant pull request, especially those that add a new library or change existing tests, otherwise you risk spending a lot of time working on something that might not end up being merged into the project. Before opening a pull request, please ensure: - [x] You have followed our [**contributing guidelines**](https://github.com/react-boilerplate/react-boilerplate/blob/master/.github/CONTRIBUTING.md) - [x] double-check your branch is based on `dev` and targets `dev` - [ ] Pull request has tests (we are going for 100% coverage!) - [ ] Code is well-commented, linted and follows project conventions - [x] Documentation is updated (if necessary) - [ ] Internal code generators and templates are updated (if necessary) - [x] Description explains the issue/use-case resolved and auto-closes related issues Be kind to code reviewers, please try to keep pull requests as small and focused as possible :) **IMPORTANT**: By submitting a patch, you agree to allow the project owners to license your work under the terms of the [MIT License](https://github.com/react-boilerplate/react-boilerplate/blob/master/LICENSE.md).
Resolves #2353
… to help the babel 6 => 7 transition
- Fixes - Linting/prettier - Dependency upgrades - Switch Appveyor to `npm ci` - More incoming
* Fix VS Code debugging instructions + spelling/grammar * Moar spelling * Capitalz * Created a section for RBP forks to clean up the electron stuff and add gretzky's SSR repo
Keep dev branch up to date with master branch
* Script enabled in travis-ci * Linting script splited
…script Fix template generator script
Fixing linting issues for generated containers
Add @rajatkantinandi as a contributor Remove tslint file Add 2 eslint scripts - eslint:quiet to run without warnings - eslint to run with warnings extend from airbnb-typescript instead of airbnb update templates & script for linting
- make eslint scripts run per file & add that to lint-staged
- Excluded gitignore internal & server paths from eslint
Remove tslint & configure to use eslint
* remove .d from types extension `.d` is meant for ambient types, for example module augmentation; in these cases however, types are explicitly exported and used directly. It's not a huge deal, but it doesn't work in some cases, for example, with `tsconfig-paths-jest`, which expects plain `index.ts` files. * fix generate patterns
### Many fixes, updates and maintenances... **Changes:** - Synched with the `dev` of the original boilerplate - Switched to `react-helmet-async` - Fixed `react-app-polyfill` - Added `react-hot-loader` - Updated `internal/scripts` - Switched to `redux-injectors` - Fixed bugs that are fixed in the boilerplate - Updated `offline-plugin` to use `network-first` response strategy - Improved `internals/scripts/generate-templates-for-linting.js` script - Fixed `eslint` bugs - Updated `README` - Updated package versions
### Many fixes, updates and maintenances... **Changes:** - Synched with the `dev` of the original boilerplate - Fixed tree-shaking issues - Fixed `internal/scripts` for setup and cleaning - Updated version to `4.1` - Updated docs to contain typescript-only documentation - Improved `internals/scripts/generate-templates-for-linting.js` script - Added `babel-loader` after `ts-loader` - Updated `README` - Updated package versions and fixed the new versions' problems
|
PS: Even though I am the only one merging and reviewing, I am still following the original boilerplate methods so that anyone later can trace my steps back and have a clear view :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v4.1: Fresh and Clean Typescript
This is a minor version release. The last update was long time ago and many things have changed in the typescript version. So, instead of waiting the official v5.0 release(which is on hold for a while), we are releasing this minor version for those who are recently starting with the boilerplate. It's a clean, updated and fresh typescript version.
This version is currently synched with the dev branch at this point
Full Changelog
Main
redux-injectorslibrary and move all saga and reducer injection-related code to ittslinttoeslintInternals Updates
babel-loaderafterts-loaderreact-helmettoreact-helmet-async@babel/polyfillto `react-app-polyfillpre-committohuskyand add linting of MD filesasync/awaitsyntax inrequest.jsnginxconfiganalysisscript to runwebpackin production modereact-hot-loaderjest-dom/extend-expectjest-watch-typeaheadloadable.jsinternal/scriptsoffline-pluginto usenetwork-firstresponse strategyxvfbsetup to servicesCODEOWNERSfilecleanandsetupscriptssave-exactin.npmrcDocumentation Updates
README.md