feat: support dropdownStyle and merge dropdownMenuColumnStyle to styles prop #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## master #413 +/- ##
=======================================
Coverage 99.81% 99.81%
=======================================
Files 19 19
Lines 550 554 +4
Branches 154 157 +3
=======================================
+ Hits 549 553 +4
Misses 1 1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
RedJue
approved these changes
Jun 5, 2023
afc163
reviewed
Jun 5, 2023
afc163
reviewed
Jun 5, 2023
现在的 API 应该这么设计了 |
|
|
BoyYangzai
force-pushed
the
fix-dropdownStyle
branch
from
f3488fb to
8e9bd3b
Compare
BoyYangzai
changed the title
|
styles 的测试需要加一下 |
afc163
reviewed
Jun 9, 2023
afc163
reviewed
Jun 9, 2023
|
@BoyYangzai 请问下已经发布线上了吗，antd版本是多少，现在可以使用吗 |
zombieJ
reviewed
Jun 16, 2023
zombieJ
reviewed
Jun 19, 2023
zombieJ
reviewed
Jun 19, 2023
BoyYangzai
force-pushed
the
fix-dropdownStyle
branch
from
a4a9e30 to
9fe6751
Compare
BoyYangzai
force-pushed
the
fix-dropdownStyle
branch
from
9fe6751 to
8dd950a
Compare
zombieJ
reviewed
Jun 21, 2023
| @@ -97,8 +97,15 @@ interface BaseCascaderProps<OptionType extends BaseOptionType = DefaultOptionTyp | |||
| /** @deprecated Use `dropdownClassName` instead */ | |||
| popupClassName?: string; | |||
| dropdownClassName?: string; | |||
| /** @deprecated Use `styles.popupColumn` instead */ | |||
There was a problem hiding this comment.
上面的 popupClassName dropdownClassName 备注也更新一下~
zombieJ
reviewed
Jun 21, 2023
| @@ -17,6 +17,10 @@ function warningProps(props: InternalCascaderProps) { | |||
| popupPlacement === undefined, | |||
| '`popupPlacement` is deprecated. Please use `placement` instead.', | |||
| ); | |||
| warning( | |||
There was a problem hiding this comment.
上面还有 popupXX 废弃请用 dropdown 的wanring 也需要清理掉
|
ping |
|
@BoyYangzai 嗨 请问什么时候解决下冲突 然后合并代码呀。 |
|
@BoyYangzai 冲突了 |
|
洋仔都不冒泡了 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
测试 rc 与 antd 所有 test都通过
合并后补充 antd pr