Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: only add when sticky #1251

Merged
merged 1 commit into from
Mar 11, 2025
Merged

chore: only add when sticky #1251

merged 1 commit into from
Mar 11, 2025

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Mar 11, 2025

follow up #1250

Summary by CodeRabbit

  • Refactor
    • 优化了表格组件的样式处理逻辑,特别是针对固定表头时的列数展示,提升了整体界面的一致性和稳定性,为用户提供更流畅的查看体验。

Copy link

vercel bot commented Mar 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
table ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2025 7:58am

Copy link

coderabbitai bot commented Mar 11, 2025

Walkthrough

本次修改在 Table 组件中引入了一个新的 tableStyle 对象,用于整合原有的 style 属性,并在 isSticky 条件为真时动态添加 CSS 变量 --columns-count(值为 flattenColumns.length)。该对象随后用于设置主 table div 的样式,从而取代之前的内联样式定义。组件的整体结构和逻辑保持不变,目的在于提高代码的清晰度和可维护性。

Changes

文件 更改摘要
src/Table.tsx 新增 tableStyle 对象,通过展开现有 style 属性,并在 isSticky 为真时添加 CSS 变量 --columns-count,替换了旧的内联样式写法。

Sequence Diagram(s)

sequenceDiagram
    participant T as Table 组件
    participant S as StyleHandler
    participant D as DOM
    T->>S: 生成 tableStyle(展开 style 属性)
    alt isSticky 为真
        S->>S: 添加 '--columns-count'(使用 flattenColumns.length)
    end
    S->>D: 将 tableStyle 应用于 table div 的 style 属性
Loading

Suggested reviewers

  • afc163

Poem

我是一只快乐的小兔子,
跳跃在代码森林间,
Table 风格焕然一新,
数字和变量共舞轻快,
代码花园充满希望 🐰🌸。

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

src/Table.tsx

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the config "prettier" to extend from. Please check that the name of the config is correct.

The config "prettier" was referenced from the config file in "/.eslintrc.js".

If you still have problems, please stop by https://eslint.org/chat/help to chat with the team.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 570c0f5 and cee8122.

⛔ Files ignored due to path filters (3)
  • tests/__snapshots__/ExpandRow.spec.jsx.snap is excluded by !**/*.snap
  • tests/__snapshots__/FixedColumn.spec.tsx.snap is excluded by !**/*.snap
  • tests/__snapshots__/Table.spec.jsx.snap is excluded by !**/*.snap
📒 Files selected for processing (1)
  • src/Table.tsx (2 hunks)
🔇 Additional comments (2)
src/Table.tsx (2)

765-772: 将样式属性集中管理并优化条件应用

代码将表格样式集中到一个专用的 tableStyle 对象中,并且只在启用了粘性(sticky)布局时动态添加 CSS 变量 --columns-count。这种方式相比于直接在 JSX 中编写样式更加清晰。

这是对 #1250 PR 的一个很好的后续优化,使得样式逻辑更加清晰和有条件性。


790-790: 应用新的样式对象结构

将之前内联样式定义替换为新的 tableStyle 对象,这样代码更简洁且易于维护。

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.03%. Comparing base (570c0f5) to head (cee8122).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1251   +/-   ##
=======================================
  Coverage   98.03%   98.03%           
=======================================
  Files          76       76           
  Lines        7423     7425    +2     
  Branches     1145     1146    +1     
=======================================
+ Hits         7277     7279    +2     
  Misses        140      140           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zombieJ zombieJ merged commit 94e8f58 into master Mar 11, 2025
12 checks passed
@zombieJ zombieJ deleted the columns branch March 11, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant