refactor: replace strip-ansi with native module #2521
+9
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inspired by eslint/eslint#18982 This API is built-in since node 16.11. react-native-cli already requires node 18 as of last year.
stianjensen
force-pushed
the
remove-strip-ansi
branch
from
bf3dec8
to
9ce9be2
Compare
|
Not sure if this windows snapshot diff could be related to this PR or not? |
|
@stianjensen not really, failure on E2E Windows pipeline was caused by other change that landed on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by eslint/eslint#18982
This API is built-in since node 16.11. react-native-cli already requires node 18 as of last year.