Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: install Cocoapods by default in all projects #2602

Merged

Conversation

szymonrybczak
Copy link
Collaborator

Summary

In #2116 we introduced opt-in way to install Cocoapods in run-ios commands, this PR changes that to be opt-out.

Test Plan

With empty react-native.config.js Cocoapods should still install.

Checklist

  • Documentation is up to date.
  • Follows commit message convention described in CONTRIBUTING.md.
  • For functional changes, my test plan has linked these CLI changes into a local react-native checkout (instructions).

@github-actions github-actions bot added docs Documentation change feature labels Feb 18, 2025
Copy link
Member

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good! We should wait for the 0.79 cut to merge this, right?

@cipolleschi
Copy link
Contributor

These changes will go "live" when we cut 0.79, but they are already in main.

I think you can merge this on main already... Until we cut the next release of the CLI, they won't be available to our users, no?

@szymonrybczak
Copy link
Collaborator Author

Until we cut the next release of the CLI, they won't be available to our users, no?

Yes, that's right.

@szymonrybczak szymonrybczak merged commit 955a39a into main Feb 21, 2025
8 checks passed
@szymonrybczak szymonrybczak deleted the feat/install-cocoapods-by-default-in-all-projects branch February 21, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation change feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants