Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JAVA_HOME is missing #97

Merged
merged 1 commit into from
Oct 27, 2020
Merged

JAVA_HOME is missing #97

merged 1 commit into from
Oct 27, 2020

Conversation

safaiyeh
Copy link
Member

@safaiyeh safaiyeh commented Oct 27, 2020 •
edited
Loading

@safaiyeh safaiyeh mentioned this pull request Oct 27, 2020
Closed
hramos
hramos approved these changes Oct 27, 2020
View reviewed changes
Copy link
Collaborator

@hramos hramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this once tests pass.

@safaiyeh
Copy link
Member Author

Merging as the failed test is related & tracked with #93

@safaiyeh safaiyeh merged commit 7da8cc2 into master Oct 27, 2020
@safaiyeh safaiyeh deleted the safaiyeh-java-home branch October 27, 2020 22:38
@gengjiawen
Copy link
Member

Any thought on removing java_home check ? I am pretty positive it's not required to build react-native and common android application.

@safaiyeh
Copy link
Member Author

Any thought on removing java_home check ? I am pretty positive it's not required to build react-native and common android application.

I'll leave this question to @hramos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hramos hramos hramos approved these changes

@gengjiawen gengjiawen Awaiting requested review from gengjiawen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@safaiyeh @gengjiawen @hramos