[Fix][useKeyboard] Adapt unsubscription for new EventEmitter API

[retyui]

Summary

Issue: #268 (comment)

// React Native 0.65.x +
typeof Keyboard.removeListener // function
Keyboard.removeListener(...) // print warning

Test Plan

What's required for testing (prerequisites)?

• React Native >= 0.65

What are the steps to reproduce (after prerequisites)?

Compatibility

OS	Implemented
iOS	✅
Android	✅
Web	✅

Checklist

• I have tested this on a device and a simulator
• I added the documentation in README.md
• I updated the typed files (TS and Flow)
• I've created a snack to demonstrate the changes: LINK HERE

[retyui]

This check work until the RN team decided to restore this method: facebook/react-native@035718b

Restore deprecated event listener removal methods in order to minimize breaking changes for the next release. The methods will work, but they will not report a warning via console.error.

[wildseansy]

To support versions <= 0.64

if (subscriptions[0]?.remove) {
  subscriptions.forEach((subscription) => subscription.remove())
} else {
    Keyboard.removeListener('keyboardWillShow', handleKeyboardWillShow)
    Keyboard.removeListener('keyboardDidShow', handleKeyboardDidShow)
    Keyboard.removeListener('keyboardWillHide', handleKeyboardWillHide)
    Keyboard.removeListener('keyboardDidHide', handleKeyboardDidHide)
}

[retyui]

I checked 0.60.x , 0.61.x, 0.62.x RN versions

and in these versions addEventListner returned subscription with remove method

[LinusU]

subscriptions[0] always exists here.

Suggested change

	if (typeof subscriptions?.[0]?.remove === 'function') {
	if (typeof subscriptions[0].remove === 'function') {

[retyui]

I recheck it on latest versions

[retyui]

you right RN [0.59.x...0.6x.x] always return EmitterSubscription with remove method, so this if block don't make sense anymore

https://github.com/facebook/react-native/blob/c20070f10458d48d6ac1eaac49e681e932bfb9fd/Libraries/EventEmitter/NativeEventEmitter.js#L41-L50

[LinusU]

Neat, just one small nit

[LinusU]

Amazing! 🎉

[pvinis]

🚀 PR was released in v2.8.1 🚀

[wildseansy]

Just to be clear, v2.8.1 won't support <= v0.64 anymore, which uses removeListener - https://reactnative.dev/docs/0.64/keyboard

[wildseansy]

Oh yay! thanks for checking

…

On Sat, Nov 13, 2021 at 2:44 AM David NRB ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In src/useKeyboard.ts <#279 (comment)> : > @@ -50,17 +50,17 @@ export function useKeyboard() { ] return () => { - if (Keyboard.removeListener) { I checked 0.60.x , 0.61.x, 0.62.x RN versions and in these versions addEventListner returned subscription with remove method — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#279 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABLNQJORDEF4RYYHZ7T63DULY6QHANCNFSM5H3KRAYQ> .