Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RN of measure to 0.55 #34

Open
wants to merge 2 commits into
base: next
Choose a base branch
from

Conversation

charpeni
Copy link
Member

@charpeni charpeni commented May 28, 2018

Related to #30.

I've updated react native of the profiler app to 0.55.4.

Unfortunately, the performance looks the same.

On a side note, it looks like we're having an issue with Yoga in the deep render test. With 0.44 or 0.55 I got this crash:

05-28 16:46:07.660 2613-2635/? A/art: vendor/intel/art-extension/runtime/indirect_reference_table.cc:115] JNI ERROR (app bug): local reference table overflow (max=512)
    vendor/intel/art-extension/runtime/indirect_reference_table.cc:115] local reference table dump:
    vendor/intel/art-extension/runtime/indirect_reference_table.cc:115]   Last 10 entries (of 512):
    vendor/intel/art-extension/runtime/indirect_reference_table.cc:115]       511: 0x132957b0 com.facebook.yoga.YogaNode
    vendor/intel/art-extension/runtime/indirect_reference_table.cc:115]       510: 0x13295740 com.facebook.yoga.YogaNode
    vendor/intel/art-extension/runtime/indirect_reference_table.cc:115]       509: 0x132956d0 com.facebook.yoga.YogaNode
    vendor/intel/art-extension/runtime/indirect_reference_table.cc:115]       508: 0x13295660 com.facebook.yoga.YogaNode
    vendor/intel/art-extension/runtime/indirect_reference_table.cc:115]       507: 0x132955f0 com.facebook.yoga.YogaNode
    vendor/intel/art-extension/runtime/indirect_reference_table.cc:115]       506: 0x13295580 com.facebook.yoga.YogaNode
    vendor/intel/art-extension/runtime/indirect_reference_table.cc:115]       505: 0x13295510 com.facebook.yoga.YogaNode
    vendor/intel/art-extension/runtime/indirect_reference_table.cc:115]       504: 0x132954a0 com.facebook.yoga.YogaNode
    vendor/intel/art-extension/runtime/indirect_reference_table.cc:115]       503: 0x13295430 com.facebook.yoga.YogaNode
    vendor/intel/art-extension/runtime/indirect_reference_table.cc:115]       502: 0x132953c0 com.facebook.yoga.YogaNode
    vendor/intel/art-extension/runtime/indirect_reference_table.cc:115]   Summary:
    vendor/intel/art-extension/runtime/indirect_reference_table.cc:115]       511 of com.facebook.yoga.YogaNode (511 unique instances)
    vendor/intel/art-extension/runtime/indirect_reference_table.cc:115]         1 of java.lang.Thread
    vendor/intel/art-extension/runtime/indirect_reference_table.cc:115] 
05-28 16:46:07.670 2613-2635/? A/art: vendor/intel/art-extension/runtime/runtime.cc:379] Runtime aborting...
    vendor/intel/art-extension/runtime/runtime.cc:379] Aborting thread:
    vendor/intel/art-extension/runtime/runtime.cc:379] "mqt_native_modules" prio=5 tid=15 Runnable
    vendor/intel/art-extension/runtime/runtime.cc:379]   | group="" sCount=0 dsCount=0 obj=0x13073d60 self=0xecf5d700
    vendor/intel/art-extension/runtime/runtime.cc:379]   | sysTid=2635 nice=0 cgrp=default sched=0/0 handle=0xdbc51930
    vendor/intel/art-extension/runtime/runtime.cc:379]   | state=R schedstat=( 215136166 7494225 77 ) utm=20 stm=1 core=2 HZ=100
    vendor/intel/art-extension/runtime/runtime.cc:379]   | stack=0xdbb4f000-0xdbb51000 stackSize=1038KB
    vendor/intel/art-extension/runtime/runtime.cc:379]   | held mutexes= "abort lock" "mutator lock"(shared held)
    vendor/intel/art-extension/runtime/runtime.cc:379]   at com.facebook.yoga.YogaNode.jni_YGNodeCalculateLayout(Native method)
    vendor/intel/art-extension/runtime/runtime.cc:379]   at com.facebook.yoga.YogaNode.calculateLayout(YogaNode.java:198)
    vendor/intel/art-extension/runtime/runtime.cc:379]   at com.facebook.react.uimanager.ReactShadowNode.calculateLayout(ReactShadowNode.java:371)
    vendor/intel/art-extension/runtime/runtime.cc:379]   at com.facebook.react.uimanager.UIImplementation.calculateRootLayout(UIImplementation.java:781)
    vendor/intel/art-extension/runtime/runtime.cc:379]   at com.facebook.react.uimanager.UIImplementation.updateViewHierarchy(UIImplementation.java:550)
    vendor/intel/art-extension/runtime/runtime.cc:379]   at com.facebook.react.uimanager.UIImplementation.dispatchViewUpdates(UIImplementation.java:539)
    vendor/intel/art-extension/runtime/runtime.cc:379]   at com.facebook.react.uimanager.UIManagerModule.onBatchComplete(UIManagerModule.java:523)
    vendor/intel/art-extension/runtime/runtime.cc:379]   at com.facebook.react.cxxbridge.NativeModuleRegistry.onBatchComplete(NativeModuleRegistry.java:103)
    vendor/intel/art-extension/runtime/runtime.cc:379]   at com.facebook.react.cxxbridge.CatalystInstanceImpl$BridgeCallback.onBatchComplete(CatalystInstanceImpl.java:154)
    vendor/intel/art-extension/runtime/runtime.cc:379]   at com.facebook.react.bridge.queue.NativeRunnable.run(Native method)
    vendor/intel/art-extension/runtime/runtime.cc:379]   at android.os.Handler.handleCallback(Handler.java:739)
    vendor/intel/art-extension/runtime/runtime.cc:379]   at android.os.Handler.dispatchMessage(Handler.java:95)
    vendor/intel/art-extension/runtime/runtime.cc:379]   at com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage(MessageQueueThreadHandler.java:31)
    vendor/intel/art-extension/runtime/runtime.cc:379]   at android.os.Looper.loop(Looper.java:148)
    vendor/intel/art-extension/runtime/runtime.cc:379]   at com.facebook.react.bridge.queue.MessageQueueThreadImpl$3.run(MessageQueueThreadImpl.java:208)
    vendor/intel/art-extension/runtime/runtime.cc:379]   at java.lang.Thread.run(Thread.java:818)

@DanielZlotin
Copy link
Collaborator

Reproduced it. Lowering the tree depth to 500 in the render deep test seems stable.
Looks like a libyoga stackoverflow issue..
Let's not merge this update until this is not resolve (an issue should be opened in react-native or yoga repo) or we HAVE to.. currently there's little benefit in updating..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants