fix(iOS): clearAll(true) method with useWebKit enabled
#23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @jackmu95 I appreciate the PR! |
safaiyeh
approved these changes
Jan 26, 2020
react-native-community-bot
pushed a commit
that referenced
this pull request
Jan 26, 2020
## [2.0.1](v2.0.0...v2.0.1) (2020-01-26) ### Bug Fixes * **iOS:** clearAll(true) correctly clears WebKit cookies ([#23](#23)) ([68d7620](68d7620))
|
🎉 This PR is included in version 2.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the
clearAll(true)method with theuseWebKitoption enabled.All credits go to @mattvick! This is a straight copy of his PR.
Test Plan
What's required for testing (prerequisites)?
An iOS device/simulator and some cookies set for
WKHTTPCookieStore.What are the steps to reproduce (after prerequisites)?
Try to clear
WKHTTPCookieStorecookies with theclearAll(true)method.Compatibility
Checklist
README.mdCHANGELOG.mdexample/App.js)