Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Badge priority class always present like in all other components #561

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

adamkudrna
Copy link
Member

⚠️ This change affects output HTML and may break downstream snapshot tests.

@github-actions github-actions bot added the BC Breaking change label Aug 31, 2024
@adamkudrna adamkudrna added this to the v1.0.0 milestone Sep 2, 2024
Copy link
Collaborator

@atmelmicro atmelmicro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/components/Button/helpers/getRootPriorityClassName.js is not used anymore, afaik it is safe to delete


Snímek obrazovky 2024-09-03 v 13 15 58 Filled badges do not have the priority class

This change affects output HTML and may break downstream snapshot tests.
@adamkudrna adamkudrna force-pushed the bc/badge-priority-class branch from 2c491b8 to c3e3222 Compare September 11, 2024 15:27
@adamkudrna adamkudrna merged commit 5bcecab into master Sep 11, 2024
10 of 11 checks passed
@adamkudrna adamkudrna deleted the bc/badge-priority-class branch September 11, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BC Breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants