Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Node 22 (current LTS) for development #573

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Conversation

adamkudrna
Copy link
Member

@adamkudrna adamkudrna commented Oct 21, 2024

  • Drop Node 18 for testing builds.
  • Add Node 22.x to dev engines.

@bedrich-schindler
Copy link
Contributor

I would update package.json in such way, that I would remove engines section and introduce devEngines:

  "devEngines": {
    "node": "20.x || 22.x"
  },

This is how React does it. RUI does not required any specific version to run, only dev environment does.

What do you think @adamkudrna @mbohal ?

@mbohal
Copy link
Contributor

mbohal commented Oct 22, 2024

I agree with using devEngines. However the code example provided by @bedrich-schindler is wrong.

See: https://docs.npmjs.com/cli/v10/configuring-npm/package-json#devengines for usage. I wonder if we should fail or warn on error. I think I would prefer to fail…

@mbohal mbohal self-requested a review October 22, 2024 11:57
@bedrich-schindler
Copy link
Contributor

@mbohal good point. It is weird that library like React have it wrong, but you are right unless there is some undocumented approach.

package.json Show resolved Hide resolved
Drop Node 18 for testing builds. Add Node 22.x to dev engines.
@adamkudrna adamkudrna changed the title Use Node 22 (upcoming LTS) for development Use Node 22 (current LTS) for development Nov 4, 2024
@adamkudrna adamkudrna merged commit 3808ce4 into master Nov 4, 2024
11 checks passed
@adamkudrna adamkudrna deleted the maintenance/node-22 branch November 4, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants