Make text links underlined by default #577 #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbohal
reviewed
Dec 4, 2024
bedrich-schindler
approved these changes
Dec 6, 2024
Links in `Alert` now inherit the font weight which is consistent with other links in React UI.
Since the color inheritance for links has been introduced in #492, links in e.g. validation messages cannot be distinguished from regular text until hovered. We chose to underline all text links by default to make those links discoverable by users.
adamkudrna
force-pushed
the
bc/577-link-style
branch
from
2d506c6 to
d8b0e6a
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.
Allow configurationRemove configurable font weight of links insideAlert#577Default font weight of links is now set to "regular" so it is consistent with other links in React UI. However, it remains configurable because of downstream project requirements.Links in
Alertnow inherit the font weight which is consistent with other links in React UI.2. Make text links underlined by default #577
Since the color inheritance for links has been introduced in #492, links in e.g. validation messages cannot be distinguished from regular text until hovered. We chose to underline all text links by default to make those links discoverable by users.
New CSS custom property:
Closes #577