Skip to content

Transform Layouts jest tests into playwright (#594) #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2025
Merged

Transform Layouts jest tests into playwright (#594) #618

merged 1 commit into from
May 5, 2025

Conversation

lukasbriza
Copy link
Collaborator

@lukasbriza lukasbriza commented Apr 9, 2025 •
edited
Loading

Transform Layout jest tests into playwright.

@bedrich-schindler I'm not sure if nested categories (describe blocks) align with our testing structure strategy, so I'm open to discussing possible changes.

Closes #594

@lukasbriza lukasbriza added the testing Anything related just to testing label Apr 9, 2025
@lukasbriza lukasbriza requested a review from adamkudrna as a code owner April 11, 2025 09:30
@bedrich-schindler bedrich-schindler force-pushed the refactoring/inputs-jest-to-playwright branch from b576522 to 63101c4 Compare April 15, 2025 12:57
Base automatically changed from refactoring/inputs-jest-to-playwright to next April 15, 2025 13:03
@bedrich-schindler
Copy link
Contributor

@lukasbriza, please rebase this PR onto next branch. Drop all the commits except those introduced in this PR. I will require to regenerate the snapshots as master dropped fonts so system fonts are now used.

@lukasbriza lukasbriza force-pushed the refactoring/layouts-jest-to-playwright branch from 0d1c727 to 23c809b Compare April 16, 2025 04:41
@lukasbriza
Copy link
Collaborator Author

@lukasbriza, please rebase this PR onto next branch. Drop all the commits except those introduced in this PR. I will require to regenerate the snapshots as master dropped fonts so system fonts are now used.

@bedrich-schindler Rebased.

@bedrich-schindler
Copy link
Contributor

@lukasbriza, please, check if tests are passing every time you push. Tests were failing due to rebase. I pushed updated snapshots so I can finish the review.

@lukasbriza
Copy link
Collaborator Author

@bedrich-schindler Added tests for autoWidth, but not sure if I should adjust the environment first. What do you think?

@bedrich-schindler
Copy link
Contributor

@bedrich-schindler Added tests for autoWidth, but not sure if I should adjust the environment first. What do you think?

Yes, please.

@lukasbriza
Copy link
Collaborator Author

lukasbriza commented Apr 29, 2025 •
edited
Loading

@bedrich-schindler Added tests for autoWidth, but not sure if I should adjust the environment first. What do you think?

Yes, please.

On call we decided that this property should be removed from FormLayout.
This will be resolved in #628

@lukasbriza lukasbriza force-pushed the refactoring/layouts-jest-to-playwright branch from 9d05fae to 8445221 Compare May 5, 2025 07:33
@lukasbriza
Copy link
Collaborator Author

Rebased and squashed.

@lukasbriza lukasbriza merged commit d1b905e into next May 5, 2025
9 of 10 checks passed
@lukasbriza lukasbriza deleted the refactoring/layouts-jest-to-playwright branch May 5, 2025 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bedrich-schindler bedrich-schindler bedrich-schindler approved these changes

@mbohal mbohal Awaiting requested review from mbohal mbohal is a code owner

@adamkudrna adamkudrna Awaiting requested review from adamkudrna adamkudrna is a code owner

Assignees

@lukasbriza lukasbriza

Labels
refactoring testing Anything related just to testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukasbriza @bedrich-schindler