Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always ping Mod in Convene Mods, fix Track for new message types #80

Merged
merged 9 commits into from
Oct 21, 2024

Conversation

vcarl
Copy link
Member

@vcarl vcarl commented Oct 21, 2024

No description provided.

Copy link

what-the-diff bot commented Oct 21, 2024

PR Summary

  • Updated core components for interactions with threads: The main functionality of this PR lies in the updates to the convene.tsx file. The update reintroduces the ApplicationCommandType from a specific library called discord-api-types/v10, which provides types used in interacting with Discord's API. An existing component, named Confirmation, has been removed and replaced with a simpler method of providing temporary replies during thread creation. Dead code categorized under the non-existent resolution case okay has been cleaned up which simplifies the case handling.

  • Refinements in notifying and interacting with moderators: The changes made to ModResponse.tsx and modResponse.ts improve communication with the moderators. This has been accomplished by transforming the textual responses to now mention the moderator role and removing unused components, thereby simplifying the code.

  • Introduction of new function for formatting poll content: The discord.ts file has been enhanced by adding a new function quoteAndEscapePoll dedicated to formatting poll content properly. Following this addition, modLog.ts has been upgraded to use this new function to handle reporting of messages which include polls.

  • Adjustments to accommodate the imported type and dependencies: Other files such as demo.ts, report.ts and track.tsx have been slightly adjusted to utilize ApplicationCommandType from discord-api-types/v10. The package.json has also been updated to include discord-api-types as a new dependency and upgrade discord.js to a new version.

  • Enhancement in TypeScript Typechecking command: The command used for typechecking in TypeScript has been changed in package.json. This enhances the efficiency of the project's build process.

This PR, in summary, streamlines the application's interaction with Discord's API, improves user-moderator communication, and enhances some features like poll message formatting.

@vcarl
Copy link
Member Author

vcarl commented Oct 21, 2024

Not sure why types suddenly started erroring, skipLibCheck is enabled and all the errors are from node_modules/ 🤔

@vcarl
Copy link
Member Author

vcarl commented Oct 21, 2024

I "love" unexpected errors that require extensive dependency updates

@vcarl vcarl merged commit 7f1faed into main Oct 21, 2024
5 checks passed
@vcarl vcarl deleted the vc-tweaks branch October 21, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant