This repository has been archived by the owner on Sep 21, 2022. It is now read-only.
Disallow applying same discount code to a cart more than once #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tedraykov <[email protected]>
brent-hoover
suggested changes
Feb 20, 2022
| billing.data && | ||
| billing.data.discountId === discount._id); | ||
|
|
||
| if (match) throw new ReactionError("discount-error", `Code ${discount.code} is already applied to cart`); |
There was a problem hiding this comment.
Could we write a test for this new function?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves reactioncommerce/reaction#6482
Impact: minor
Type: bugfix
Issue
A discount code can be applied multiple times to a single cart.