Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix console warnings/errors #125

Merged
merged 3 commits into from
Oct 18, 2019
Merged

fix console warnings/errors #125

merged 3 commits into from
Oct 18, 2019

Conversation

mikemurray
Copy link
Member

Resolves #122
Impact: minor
Type: bugfix

Component

  • Remove unused prop on the page select text field in DataTable
  • Update peer dep of the prop-types package to 15.7.2
  • Update the dependency of docs site for prop-types to match

Breaking changes

none

Testing

  1. Go to the DataTable docs, see that there is no warnings for ForwardRef(SomeComponent), or disableUnderline

@mikemurray
fix: remove invalid prop
b312ebf 
Signed-off-by: Mike Murray <[email protected]>
@mikemurray
fix: update prop-types peer-dep
07be8cb 
Fixes pro-types warnings for ForwardRef components

Signed-off-by: Mike Murray <[email protected]>
@mikemurray
fix: update prop-types to fix warnings
a1df9d1 
Signed-off-by: Mike Murray <[email protected]>
@netlify
Copy link

netlify bot commented Oct 18, 2019

Deploy preview for heuristic-perlman-0ef024 ready!

Built with commit a1df9d1

https://deploy-preview-125--heuristic-perlman-0ef024.netlify.com

@machikoyasuda
Copy link
Contributor

I don't see ForwardRef or disableUnderline errors.

For the record, I see these:

Screen Shot 2019-10-18 at 2 45 47 PM

Screen Shot 2019-10-18 at 2 45 50 PM

@machikoyasuda machikoyasuda merged commit d4102c3 into master Oct 18, 2019
@rc-publisher
Copy link
Collaborator

🎉 This PR is included in version 1.14.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@rc-publisher rc-publisher added the released Applied automatically by semantic-release label Oct 18, 2019
@mikemurray mikemurray deleted the fix-mikemurray-122-errors branch October 18, 2019 22:07
@janus-reith
Copy link

janus-reith commented Oct 19, 2019 •
edited
Loading

Thanks, the original warnings are gone except for the actionMenuProps of type object one
I just noticed additional ones, that only occur on initially when loading a DataTable: #126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machikoyasuda machikoyasuda machikoyasuda approved these changes

Assignees
No one assigned
Labels
released Applied automatically by semantic-release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DataTable: Throws warnings about failed prop types
4 participants
@mikemurray @machikoyasuda @rc-publisher @janus-reith