This repository has been archived by the owner on Dec 11, 2022. It is now read-only.
Update to Meteor 2.0 and enable HMR #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Loan Laux <[email protected]>
Signed-off-by: Loan Laux <[email protected]>
|
Let's wait until the |
Signed-off-by: Loan Laux <[email protected]>
|
@loan-laux Do you still want to keep this around? |
|
@Akarshit I'll resolve the conflicts and then we should merge it. No harm in keeping |
Signed-off-by: Loan Laux <[email protected]>
Signed-off-by: Loan Laux <[email protected]>
Signed-off-by: Loan Laux <[email protected]>
Signed-off-by: Loan Laux <[email protected]>
loan-laux
force-pushed
the
loan-update-meteor-2.0
branch
from
d665d90 to
a5d57ef
Compare
|
Not sure why Snyk keeps on failing. I've resolved every security warning that |
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact: minor
Type: performance|chore
Issue
Meteor was outdated as version 2.0 recently came out. This version introduces HMR with React Fast Refresh, making for a better developer experience when working on the front-end.
Solution
Update to Meteor 2.0 and enable HMR.
Breaking changes
None.
Testing
reaction-identity, check that the UI is working as it should.