-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync with react.dev @ 7bdbab14 #264
Open
react-translations-bot
wants to merge
258
commits into
main
Choose a base branch
from
sync-7bdbab14
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sentence reads: In this solution, two separate conditions are used to insert a space between then name and the importance label. It should read: In this solution, two separate conditions are used to insert a space between the name and the importance label.
See facebook/react#26761 for more context.
This reverts commit aa88d8a.
* Revert "Revert "Canaries blog post"" This reverts commit 9a865fd. * words --------- Co-authored-by: Sophie Alpert <[email protected]>
…de.js stream) (#6001)
…(#6003) Mounting with Suspense and Offscreen can happen multiple times. This removes some wording that implies a that effects / lifecycle hooks only happen on first mount.
Otherwise the address is being offset to the right when the refresh icon is not displayed
… (#6026) * Add accessibility note to interactivity section in the new React docs * Add a11y note to Responding to Events section * Update responding-to-events.md --------- Co-authored-by: dan <[email protected]>
* Upgrade React and Next * Fix bug in useNestedScrollLock I guess refs get disconnected before passive effect cleanup runs. useLayoutEffect would also fix it but maybe this is better.
* Fix manipulating-the-dom-with-refs * Update manipulating-the-dom-with-refs.md --------- Co-authored-by: dan <[email protected]>
…utilize Node.js v16 (#6084) * Update site_lint.yml * Update site_lint.yml
The inner component is `EditForm`, not `EditContact`.
* Add basic reference pages for use client and server I guess this turned into a bit more of an FAQ but I think it's useful to have this written down in a canonical place. * Oops, push final tweaks
this is the canonical link now 🫡
"React Complier" → "React Compiler" "and alternative history" → "an alternative history"
* Update renderToNodeStream.md * Update renderToStaticMarkup.md * Update renderToStaticNodeStream.md * Update renderToString.md
Removed the redundant alternative state management suggestion. The documentation already emphasizes the elimination of duplication by advising to hold the selected ID in state, making the alternative suggestion unnecessary.
* Remove useMemo from useFormStatus example * nits
…#6659) * fix: Update @codesandbox/sandpack-react version to 2.13.1 * fix: Updated the bundlerURL to use a new URL
… error (…" (#6663) This reverts commit 081d100.
* fix: Update @codesandbox/sandpack-react version to 2.13.3 * fix: Fixed bundlerURL to use the correct URL * fix: Update @codesandbox/sandpack-react to version 2.13.4 * style: Hide span element in sp-icon-standalone when loading
…updated docs (#6669)
* Add /link redirects * Update event pooling redirect
* Update useDeferredValue.md change text from "re-render in background" to "re-render in the background" * Update useDeferredValue.md Change instances of "in background" to "in the background".
It seems like these localhost references were being stripped out anyway, so this isn't a bugfix but just a small cleanup.
This PR adds a new Rules of React reference section that covers the major rules that help developers author idiomatic React apps. --------- Co-authored-by: Sathya Gunasekaran <[email protected]>
Small change to match the sidebar order.
Co-authored-by: Sebastian Silbermann <[email protected]> Co-authored-by: Allison Strandberg <[email protected]>
This example contains a list of person objects, but only the first 3 have id properties. This appears to be a mistake; in the next use of the list all 5 person objects have this property, but it is not changed as part of an instructive exercise. This change makes the final two with objects consistent with the remainder of the list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically generated.
Merge changes from react.dev at 7bdbab1
DO NOT SQUASH MERGE THIS PULL REQUEST!
Doing so will "erase" the commits from main and cause them to show up as conflicts the next time we merge.