Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: translate "State: A Component's Memory" #492

Merged
merged 14 commits into from
Jun 7, 2023
Merged

docs: translate "State: A Component's Memory" #492

merged 14 commits into from
Jun 7, 2023

Conversation

krowter
Copy link
Contributor

@krowter krowter commented Apr 29, 2023

@krowter krowter marked this pull request as ready for review April 30, 2023 09:26
@krowter krowter mentioned this pull request Apr 30, 2023
Closed
@resir014 resir014 changed the title docs(State: A Component's Memory) docs: translate "State: A Component's Memory" Apr 30, 2023
@github-actions
Copy link

github-actions bot commented Apr 30, 2023 •
edited
Loading

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

mhaidarhanif
mhaidarhanif requested changes Apr 30, 2023
View reviewed changes
Copy link
Collaborator

@mhaidarhanif mhaidarhanif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An improvement.

@krowter
Copy link
Contributor Author

krowter commented May 6, 2023

Just got the chance to work on this again 😁
Suggestions committed.

@krowter krowter requested a review from mhaidarhanif May 6, 2023 04:25
r17x
r17x previously requested changes May 7, 2023
View reviewed changes
Copy link
Collaborator

@r17x r17x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Permintaan perubahan meliputi:

  • Gunakan * daripada _ untuk membuat tulisan miring italic
  • Buat tulisan miring pada kata serapan (bukan Bahasa Indonesia), seperti render, state, atau props.

@krowter
docs(State: A Component's Memory): replace _ with * for italics; and …
70c72b3 
…italicise foreign word (state, props, render)
@krowter krowter requested a review from r17x May 20, 2023 08:13
resir014
resir014 requested changes May 26, 2023
View reviewed changes
Copy link
Member

@resir014 resir014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some requested changes. @krowter

Also, please change the page title to "State: Memori dari Sebuah Komponen"

@mhaidarhanif
Copy link
Collaborator

mhaidarhanif commented Jun 4, 2023 •
edited
Loading

@krowter Please fix and resolve this to be approved by @resir014 @r17x and me

@mhaidarhanif
Copy link
Collaborator

I approved to avoid future blocking, now can be approved by @resir014 @r17x once the issues have been resolved

@krowter
Copy link
Contributor Author

krowter commented Jun 4, 2023

Sorry. I missed the notification email.
Will fix tomorrow morning, asap

@krowter krowter requested a review from resir014 June 5, 2023 06:11
@mhaidarhanif
Copy link
Collaborator

@resir014 @r17x can check and approve if everything's okay

@resir014 resir014 dismissed r17x’s stale review June 7, 2023 06:36

Changes are made and co-approved.

@resir014 resir014 merged commit 4ce3563 into reactjs:main Jun 7, 2023
FelixFern pushed a commit to FelixFern/id.react.dev that referenced this pull request Jun 13, 2023
@krowter @mhaidarhanif @FelixFern
docs: translate "State: A Component's Memory" (reactjs#492)
a39d99d 
Co-authored-by: M Haidar Hanif <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhaidarhanif mhaidarhanif mhaidarhanif approved these changes

@resir014 resir014 resir014 approved these changes

@zainfathoni zainfathoni Awaiting requested review from zainfathoni

@r17x r17x Awaiting requested review from r17x

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

State: A Component's Memory
4 participants
@krowter @mhaidarhanif @resir014 @r17x