Handle the incoming LastHttpContent with no content as if it is EMPTY_LAST_CONTENT
#3530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_LAST_CONTENT When the incoming LastHttpContent is EMPTY_LAST_CONTENT, Reactor Netty directly completes the inbound. Handle the incoming LastHttpContent with no content in the same way instead of buffering it in FluxReceive. Adapt the tests - instead of counting the received content on the server, directly count the outbound data on the client.
chemicL
approved these changes
Dec 4, 2024
|
@chemicL Thanks for the review! |
violetagg
added a commit
that referenced
this pull request
Dec 4, 2024
violetagg
added a commit
that referenced
this pull request
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the incoming
LastHttpContentisEMPTY_LAST_CONTENT, Reactor Netty directly completes the inbound. Handle the incomingLastHttpContentwith no content in the same way instead of buffering it inFluxReceive.Adapt the tests - instead of counting the received content on the server, directly count the outbound data on the client
as the modified test is aimed at the client request outbound frames.