-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RAPPS-DB] Convert .zip to generated installers #291
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I skimmed through your proposed changes, I haven't found any weird things per se (except the apparent redundant Section.amd64
for one entry).
I guess that if one wants to accurately double-check your proposal, one would have to systematically install each individual zip-provided app to verify that the generated installer will correctly delete all the created (incl. extra temporary) files.
|
||
[Generate] | ||
DelReg = HKCU\Software\Petr Lastovicka\calc | ||
DelRegEmpty = HKCU\Software\Petr Lastovicka |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Side-question: does the parser allows for specifying values within quotes (like: DelRegEmpty = "HKCU\Software\Petr Lastovicka"
) yet doing the correct thing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, |
is the separator, it does not care about spaces. Quotes are problematic because some .ini parsers will remove them (not sure if Rapps does).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rapps uses the standard windows ini parser, which understands the external quotes.
See https://learn.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-getprivateprofilestring#remarks
the third paragraph there.
restoration.txt
Outdated
@@ -3,10 +3,11 @@ Name = Restoration | |||
Version = 3.2.13 | |||
Description = Restoration is a freeware, portable app that can restore files accidentally deleted from the recycle bin. | |||
Category = 12 | |||
URLDownload = https://files1.majorgeeks.com/10afebdbffcd4742c81a3cb0f6ce4092156b4375/drives/Restoration.zip | |||
URLDownload = https://web.archive.org/web/2024if_/https://files1.majorgeeks.com/acd9affbbee5e4c28a3a457dcf138bb1259439e4/drives/Restoration.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Different "hash" in the URL, but the resulting file's SHA1 and size (below) are the same?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the old link was dead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to be a weird old clumsy software/abandonware, and majorgeeks it's not an official source, neither the softpedia, neither the one I upload here. It's hard to find the original source. I will try to find that one.
https://web.archive.org/web/20210328174143/www3.telus.net/mikebike/Restoration.zip
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "official" home page seems to be http://web.archive.org/web/20020927194938/http://hccweb1.bai.ne.jp/~hcj58401/ but the download there is much older. I'll go with the download you found.
I pretty much tried every installer in this PR. I started the program and then tried to configure its settings dialog if it has one. I did not use the programs a lot more beyond that so I cannot guarantee that some other action does not create other files that need to be deleted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor tiny edits, I am okkay for all the other files.
restoration.txt
Outdated
@@ -3,10 +3,11 @@ Name = Restoration | |||
Version = 3.2.13 | |||
Description = Restoration is a freeware, portable app that can restore files accidentally deleted from the recycle bin. | |||
Category = 12 | |||
URLDownload = https://files1.majorgeeks.com/10afebdbffcd4742c81a3cb0f6ce4092156b4375/drives/Restoration.zip | |||
URLDownload = https://web.archive.org/web/2024if_/https://files1.majorgeeks.com/acd9affbbee5e4c28a3a457dcf138bb1259439e4/drives/Restoration.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to be a weird old clumsy software/abandonware, and majorgeeks it's not an official source, neither the softpedia, neither the one I upload here. It's hard to find the original source. I will try to find that one.
https://web.archive.org/web/20210328174143/www3.telus.net/mikebike/Restoration.zip
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In terms of PR adequacy, approved.
In terms of testing, I have still to test the behavior of all the packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on the technical aspect. Thanks for your exhaustive work!
Automatically generate installers for .zip files.
Notes: