-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor CSS/SASS/LESS imports #12
Comments
Nice work on the refactor @leebenson, I've tested this by successfully integrating Grommet on #18 |
Have you had time to make any progress re: leebenson/reactql#30 ? If so, what would be the recommended way to import sass partials? |
@Extra-lightwill - sure have, please see #13 TL;DR - Put 'global' |
@Extra-lightwill - as for a recommend way to import SASS partials, this should work just like any other SASS import. e.g.: // if you're importing locally, from your own source
@import 'src/path/to/partial';
// if you're importing from a `node_modules` npm
@import '~module/path/to/partial' |
There are currently differences in the way CSS, LESS and SASS
@import
statements resolve, causing unexpected behaviour when using~
to representnode_modules
, and relative path names that don't follow the expected Webpack setting.Needs proper testing.
The text was updated successfully, but these errors were encountered: