Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate grommet #11

Closed
wants to merge 1 commit into from
Closed

Integrate grommet #11

wants to merge 1 commit into from

Conversation

bartekus
Copy link
Contributor

So while both dev and prod compile, unlike the devServer which runs, node dist/server currently throws:

/Users/Bart/Dev/fuser/client/node_modules/grommet/scss/vanilla/index.scss:1
(function (exports, require, module, __filename, __dirname) { @import 'vanilla.defaults';
                                                              ^
SyntaxError: Invalid or unexpected token
    at createScript (vm.js:53:10)
    at Object.runInThisContext (vm.js:95:10)
    at Module._compile (module.js:543:28)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:488:32)
    at tryModuleLoad (module.js:447:12)
    at Function.Module._load (module.js:439:3)
    at Module.require (module.js:498:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/Users/Bart/Dev/fuser/client/dist/server.js:1014:18)

I'm probably doing something wrong, but I've not been yet able to figure out what nor how to remedy it.

@leebenson
Copy link
Member

@bartekus - I've opened #12, which probably relates to this. I need to standardise how @import works across plain CSS, SASS and LESS -- there are a few inconsistencies that need resolving. I'm actually working on that tonight.

Re: Grommet, I think it's best to have this listed as a guide in the docs, rather than a firm choice in the starter kit. Pulling in external CSS like this...

<link rel="stylesheet" type="text/css" href="https://cdnjs.cloudflare.com/ajax/libs/grommet/1.3.4/grommet.min.css" />

... is something I'd like to avoid, since it's enforcing opinions on styling and goes against the ethos of local style classes.

Instead, I think a dedicated 'How to add Grommet' section in the docs would be a great way to showcase these kinds of integrations. I've added it here -> reactql/docs#2

I'll close this for now, and will re-visit when it comes to doing the docs. Thanks for the PR.

@leebenson leebenson closed this Apr 19, 2017
@bartekus bartekus deleted the implement/grommet branch April 26, 2017 18:36
@leebenson leebenson mentioned this pull request Apr 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants