-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix stack overflow when searching in a book with a large TOC #473
Conversation
This fix targets version 2.7.2 |
Thanks for spotting and fixing this issue @vitaliynester! Although the |
Changed to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vitaliynester I adapted your changes to the latest develop
. But as I couldn't reproduce the issue with the book you shared, would you mind checking my changes before I merge it? Thanks.
I apologize for the long response. Yes, after these changes the search works without errors. This is great! |
Hello!
When working with a book that has a large table of contents (I attach an example file below), a problem arises with the search. When you try to enter a search query that is not present in the book, the application crashes. I fixed this by rewriting the search function from recursive to a while loop. In my case, this solution helped solve the problem.
The attached epub file has been archived because .epub is not available for attachment: epub file