Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dont bundle rdmd #1032

Merged
merged 1 commit into from
Nov 21, 2024
Merged

fix: dont bundle rdmd #1032

merged 1 commit into from
Nov 21, 2024

Conversation

kellyjosephprice
Copy link
Collaborator

PR App

🧰 Changes

Requires passing rdmd in as an option to the migration.

Bundling @readme/[email protected] was doubling the time it takes it import the dist. This can be a problem in mdx-renderer which does this with every request.

🧬 QA & Testing

@kellyjosephprice kellyjosephprice marked this pull request as ready for review November 21, 2024 21:13
@kellyjosephprice kellyjosephprice merged commit 21b7594 into next Nov 21, 2024
13 checks passed
@kellyjosephprice kellyjosephprice deleted the fix/dont-bundle-rdmd branch November 21, 2024 21:21
rafegoldberg pushed a commit that referenced this pull request Nov 21, 2024
@semantic-release-bot
build(release): 🚀 v7.10.2 🦉
8d05b7a 
## Version 7.10.2
### 🛠 Fixes & Updates

* add button labels ([#1031](#1031)) ([6555fc0](6555fc0))
* dont bundle rdmd ([#1032](#1032)) ([21b7594](21b7594))

<!--SKIP CI-->
@rafegoldberg
Copy link
Contributor

This PR was released!

🚀 Changes included in v7.10.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llimllib llimllib llimllib approved these changes

@rafegoldberg rafegoldberg Awaiting requested review from rafegoldberg

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kellyjosephprice @rafegoldberg @llimllib