Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Allows user variables in esm code.
Prior to this, user variables (eg
{user.email}
) were being replaced with a JSX component (<Variable name="email" />
) opaquely. The actual values were provided by theVariableContext
. This mimiced how they were handled in pre-mdx versions of the library. This PR undoes that, and provides theuser
object as a top level import. The following was not possible before, but is possible now:We had talked about implementing it this way, and I somehow ignored/forgot that. Oops.
The
VariableContext
is still being used, because our custom wrapper around code blocks will also insert theuser
object into the scope of the code block. eg:Also, I've left the variable transformer
processor/transform/variable
in place, because it's still being used by the editor. When callingmdast
, user variables such as{user.email}
should show up as areadme-variable
node type.🧬 QA & Testing