Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: include shrinkwrap in npm output #837

Merged
merged 1 commit into from
Mar 11, 2024
Merged

fix: include shrinkwrap in npm output #837

merged 1 commit into from
Mar 11, 2024

Conversation

kanadgupta
Copy link
Member

@kanadgupta kanadgupta commented Mar 11, 2024 •
edited
Loading

PR App Follow up to #836

🧰 Changes

This repo has a files array definition in the package.json as well as a root-level .npmignore. The former mostly renders the latter useless, so I removed the latter. I also added the npm-shrinkwrap.json file to the files array so it will be properly published to the NPM registry.

🧬 QA & Testing

To test this, you can run npm pack and you'll see a list of files that will be published. Note how npm-shrinkwrap.json now properly shows up in that list:

CleanShot 2024-03-11 at 09 07 38@2x

@kanadgupta kanadgupta added the bug Something isn't working label Mar 11, 2024
kellyjosephprice
kellyjosephprice approved these changes Mar 11, 2024
View reviewed changes
Copy link
Collaborator

@kellyjosephprice kellyjosephprice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OOOOh, thanks!

@kellyjosephprice kellyjosephprice merged commit d7b2634 into next Mar 11, 2024
9 checks passed
@kellyjosephprice kellyjosephprice deleted the kanad-2024-03-11/do-not-ignore-shrinkwrap branch March 11, 2024 17:00
rafegoldberg pushed a commit that referenced this pull request Mar 11, 2024
@semantic-release-bot
build(release): 🚀 v6.75.1 🦉
1652c61 
## Version 6.75.1

### 🛠 Fixes & Updates

* include shrinkwrap in npm output ([#837](#837)) ([d7b2634](d7b2634))

<!--SKIP CI-->
@rafegoldberg
Copy link
Contributor

This PR was released!

🚀 Changes included in v6.75.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kellyjosephprice kellyjosephprice kellyjosephprice approved these changes

@erunion erunion erunion approved these changes

Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kanadgupta @rafegoldberg @erunion @kellyjosephprice