tests: vitest #849
Merged
tests: vitest #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kellyjosephprice
commented
Apr 2, 2024
Comment on lines
+109
to
+120
| exports[`export multiple Markdown renderers > allows complex compact headings 1`] = `undefined`; | ||
|
|
||
| exports[`export multiple Markdown renderers > renders HTML 1`] = `undefined`; | ||
|
|
||
| exports[`export multiple Markdown renderers > renders MD 1`] = ` | ||
| "# Hello World | ||
| " | ||
| `; | ||
|
|
||
| exports[`export multiple Markdown renderers > renders custom React components 1`] = `[Function]`; | ||
|
|
||
| exports[`export multiple Markdown renderers > renders hAST 1`] = `undefined`; |
There was a problem hiding this comment.
Something is wrong with these tests. Not sure where the snapshots were????
kellyjosephprice
requested review from
rafegoldberg,
jennspencer and
trishaprile
|
you should also update this Line 2 in f289c1b |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Ports our test suite to
vitest!This mostly just adds the configuration and skips any tests that aren't passing already. I also deleted any magic block tests! 😃
It does not convert the browser tests to
vitest. I'd like to get them all passing before we do that???🧬 QA & Testing