chore: pr feedback; avoid mutating fn params

readmeio · Jan 5, 2022 · e8e7c31 · e8e7c31
1 parent 2729d32
commit e8e7c31
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/packages/ruby/lib/readme/har/request_serializer.rb b/packages/ruby/lib/readme/har/request_serializer.rb
@@ -31,8 +31,8 @@ def url
         headers = @request.headers
         forward_proto = headers["X-Forwarded-Proto"]
         forward_host = headers["X-Forwarded-Host"]
-        url.host = forward_host if forward_host.instance_of?(String)
-        url.scheme = forward_proto if forward_proto.instance_of?(String)
+        url.host = forward_host if forward_host.is_a?(String)
+        url.scheme = forward_proto if forward_proto.is_a?(String)
         url.to_s
       end
 

diff --git a/packages/ruby/lib/readme/payload.rb b/packages/ruby/lib/readme/payload.rb
@@ -6,14 +6,10 @@ class Payload
 
     def initialize(har, info, development:)
       @har = har
-      # swap api_key for id
-      info[:id] = info.delete :api_key unless info[:api_key].nil?
-      # pull log_id and ignore fields out of info to construct a user_info hash that can be assigned to the group key
+      @user_info = info.slice(:id, :label, :email)
+      @user_info[:id] = info[:api_key] unless info[:api_key].nil? # swap api_key for id if api_key is present
       @log_id = info[:log_id]
       @ignore = info[:ignore]
-      info.delete :log_id
-      info.delete :ignore
-      @user_info = info
       @development = development
       @uuid = UUID.new
     end