Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: moving our integration test suite over to using native fetch #1018

Merged
merged 3 commits into from
Jul 30, 2024
Merged

feat: moving our integration test suite over to using native fetch #1018

merged 3 commits into from
Jul 30, 2024

Conversation

erunion
Copy link
Member

@erunion erunion commented Jun 16, 2024

🧰 Changes

Moves out integration test suite off an outdated collection of isomorphic-fetch, form-data-encoder, and formdata-node in favor of native fetch and FormData utilizations.

@erunion erunion added the enhancement New feature or request label Jun 16, 2024
@erunion erunion changed the base branch from main to feat/modernize-sdk-snippets June 16, 2024 07:34
@erunion erunion force-pushed the feat/native-fetch-integrations branch from 7eeaa28 to d11b4eb Compare June 16, 2024 07:35
@erunion erunion changed the title feat: moving out integration test suite over to using native fetch feat: moving our integration test suite over to using native fetch Jun 16, 2024
domharrington
domharrington approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@domharrington domharrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

kanadgupta
kanadgupta approved these changes Jun 17, 2024
View reviewed changes
.github/workflows/dotnet.yml Outdated Show resolved Hide resolved
@erunion erunion marked this pull request as ready for review June 17, 2024 16:54
@erunion erunion requested a review from gratcliff July 28, 2024 06:41
@erunion erunion force-pushed the feat/native-fetch-integrations branch from 6bb06b6 to dcaa6a3 Compare July 30, 2024 00:58
@erunion erunion changed the base branch from feat/modernize-sdk-snippets to main July 30, 2024 00:58
@erunion erunion merged commit cc07ac2 into main Jul 30, 2024
40 of 41 checks passed
@erunion erunion deleted the feat/native-fetch-integrations branch July 30, 2024 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gratcliff gratcliff gratcliff approved these changes

@kanadgupta kanadgupta kanadgupta approved these changes

@domharrington domharrington domharrington approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erunion @domharrington @kanadgupta @gratcliff