test: rework how we assert command results #1084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erunion
approved these changes
Nov 22, 2024
erunion
approved these changes
Nov 22, 2024
|
🎉 This PR is included in version 9.0.0-next.33 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 9.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
this PR is a slight rework to how we assert command results using
@oclif/test(inspired by oclif/test#655). we use a mishmash of our own internal logger vsoclif'sthis.logand this sets us up for better success when we eventually unify all of this in v10.this also touches up our vitest setup a bit — hiding Node.js
ExperimentalWarningoutputs, removing an unused matcher, only importing a matcher where we use it, etc.our vitest output has been a bit of a mess lately so all of these changes culminate in a much cleaner output and i'm irrationally excited about it.
before
after
🧬 QA & Testing
no functional changes nor changes in test coverage — if tests still pass we should be in good shape.