feat(eslint): making a couple of our internal custom rules open source #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erunion
requested review from
kanadgupta,
julshotal,
mosesj-readme and
llimllib
erunion
commented
Aug 8, 2024
erunion
commented
Aug 8, 2024
| }, | ||
| create: context => { | ||
| return { | ||
| Program(node) { |
There was a problem hiding this comment.
I can see if a file actually contains TS by checking if it uses import or some sort of type but because a file could potentially have neither of those, and still be perfectly fine, I'm leaving it to just assert the filename.
Though maybe in those cases the warning could just be ignored? I'm not sure.
llimllib
approved these changes
Aug 8, 2024
kanadgupta
reviewed
Aug 8, 2024
There was a problem hiding this comment.
hard to tell when skimming through this code but is this code smart enough to distinguish spread syntax?
There was a problem hiding this comment.
yep! spreads are a SpreadElement which i'm not looking for here
Co-authored-by: Kanad Gupta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
This makes a couple of our internal ESLint rules open source by pulling them into our
eslint-plugin-readmepackage. The rules included in this are:readme/no-decorators-on-private-properties: Prevents the use of decorators on private properties as they cannot be introspected.readme/prefer-unicode-ellipsis: Prefer using a unicode ellipsis (…) instead of three periods (...).Those rules have been pulled over verbatim from our internal codebase.
In addition to that I'm also introducing a new (and definitely not enabled) rule,
readme/prefer-typescript, to prefer that a codebase is written in TypeScript by asserting file extensions.