Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger the URL_CHANGED event only if from/to URL are different #516

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

humitos
Copy link
Member

@humitos humitos commented Jan 30, 2025

Check if from/to URL are different after removing ?readthedocs-diff=
attribute because we don't want to trigger the even when the user enabled
docdiff in the current page.

Closes #506

Check if from/to URL are different after removing `?readthedocs-diff=`
attribute because we don't want to trigger the even when the user enabled
docdiff in the current page.

Closes #506
@humitos humitos requested a review from ericholscher January 30, 2025 11:55
@humitos humitos requested a review from a team as a code owner January 30, 2025 11:55
@humitos humitos requested a review from agjohnson January 30, 2025 11:55
@humitos humitos merged commit d1c96fe into humitos/lit-context-app Feb 4, 2025
4 checks passed
@humitos humitos deleted the humitos/visualdiff-url-history branch February 4, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants