Added flag enums support #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lue options to FlagProvider
daler-sz
force-pushed
the
flag-enums-support
branch
from
90e2797 to
04e91c2
Compare
# Conflicts: # src/adaptix/_internal/morphing/enum_provider.py
zhPavel
requested changes
Jan 21, 2024
daler-sz
commented
Jan 21, 2024
daler-sz
force-pushed
the
flag-enums-support
branch
from
6d14c75 to
9807899
Compare
zhPavel
requested changes
Jan 22, 2024
# Conflicts: # src/adaptix/_internal/morphing/facade/provider.py # src/adaptix/_internal/morphing/facade/retort.py
zhPavel
requested changes
Jan 25, 2024
|
The feature looks almost complete. But there is need a documentation at specific-types-behavior.rst file and docstring of high-level factory It is also necessary to add a fragment of the changelog with a description of the new feature. |
zhPavel
requested changes
Jan 26, 2024
zhPavel
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#197