Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix parse_func #45

Merged
merged 3 commits into from
Nov 11, 2024
Merged

fix parse_func #45

merged 3 commits into from
Nov 11, 2024

Conversation

chirizxc
Copy link

@chirizxc chirizxc commented Oct 30, 2024 •
edited
Loading

Fixes #44

@chirizxc chirizxc changed the title fix https://github.com/reagento/dataclass-rest/issues/44 fix #44 Oct 30, 2024
@chirizxc chirizxc changed the title fix #44 fix parse_func Oct 30, 2024
bomzheg
bomzheg approved these changes Oct 30, 2024
View reviewed changes
Copy link

@bomzheg bomzheg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this patch fixed my problem

@Tishka17
Copy link
Member

Please, add test to show the fixed case

@chirizxc
Copy link
Author

Please, add test to show the fixed case

if add from __future__ import annotations to any existing test, they return ProviderNotFoundError

@Tishka17
Copy link
Member

Let's make new test with type hint as a string

@Tishka17 Tishka17 merged commit 9b02fd9 into reagento:develop Nov 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bomzheg bomzheg bomzheg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

response body loading error
3 participants
@chirizxc @Tishka17 @bomzheg