Fixed some build/test issues

realm · Mar 4, 2024 · 180e44b · 180e44b
1 parent c69dbc0
commit 180e44b
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/realm/object-store/sync/sync_session.cpp b/src/realm/object-store/sync/sync_session.cpp
@@ -1251,7 +1251,7 @@ void SyncSession::update_access_token(const std::string& signed_token)
         m_session->refresh(signed_token);
     }
     if (m_state == State::WaitingForAccessToken) {
-        do_revive(std::move(lock));
+        become_active();
     }
 }
 

diff --git a/test/object-store/sync/app.cpp b/test/object-store/sync/app.cpp
@@ -273,7 +273,7 @@ TEST_CASE("app: verify app error codes", "[sync][app][local]") {
                 return false;
             }
         }
-        catch (const nlohmann::json::exception& ex) {
+        catch (const nlohmann::json::exception&) {
             // It's also a failure if parsing the json body throws an exception
             return false;
         }
@@ -3033,7 +3033,7 @@ TEST_CASE("app: sync integration", "[sync][pbs][app][baas]") {
         if (auto port_pos = original_host.find(":"); port_pos != std::string::npos) {
             auto original_port_str = original_host.substr(port_pos + 1);
 
-            original_port = strtol(original_port_str.c_str(), nullptr, 10);
+            original_port = static_cast<uint16_t>(strtoul(original_port_str.c_str(), nullptr, 10));
             original_address = original_host.substr(0, port_pos);
         }
 

diff --git a/test/test_sync.cpp b/test/test_sync.cpp
@@ -2943,7 +2943,7 @@ TEST_IF(Sync_SSL_Certificate_Verify_Callback_External, false)
     config.reconnect_mode = ReconnectMode::testing;
     sync::RandomEngine random;
     util::seed_prng_nondeterministically(random); // Throws
-    Client client(client_config, random);
+    Client client(config, random);
 
     auto ssl_verify_callback = [&](const std::string server_address, Session::port_type server_port,
                                    const char* pem_data, size_t pem_size, int preverify_ok, int depth) {