-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RCORE-1928 Make dependencies.list a YAML file #7394
Conversation
Pull Request Test Coverage Report for Build jonathan.reams_3067Details
💛 - Coveralls |
@@ -1,7 +1,7 @@ | |||
PACKAGE_NAME=realm-core |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest changing the file name to dependencies.yaml
to formalize the change in syntax.
This would have the effect of self documenting the expected syntax of the file, as well as intentionally breaking scripts or SDKs that depend on this which otherwise might have their parsers broken in difficult to discover ways. Either way, this change probably warrants a note in the "internals" section of the changelog.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! 👍
What, How & Why?
This is part of my work on using baasaas in core. It makes dependencies.list a YAML file so it's easier to pull into our CI environment.
☑️ ToDos
bindgen/spec.yml
, if public C++ API changed