Reduce boilerplate in collections in mixed unit test #7421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build jonathan.reams_3064Details
💛 - Coveralls |
danieltabacaru
approved these changes
Mar 6, 2024
danieltabacaru
added a commit
that referenced
this pull request
Mar 12, 2024
* Update the merge nested rules to handle sentinel instructions on conflicting data types * Allow syncing nested collections and collections in mixed * Add integration tests with the legacy sync server * Do not expose set_collection on a dictionary * Fix OT rule for add_int on Mixed fields * Small fixes * Fix linting errors * Apply Clear instructions received from the server on nested collections * Add OT rule Clear vs Update * Reduce boilerplate in collections in mixed unit test (#7421) * Document unit-tests * Changes after code review * Fix test comments & update changelog --------- Co-authored-by: Jonathan Reams <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
@danieltabacaru, I did some futzing with the collections in mixed transform unit tests so there's less boilerplate in each test to have to read/review. If you think this is an improvement I'll keep reviewing collections in mixed after this is merged.
☑️ ToDos
bindgen/spec.yml, if public C++ API changed