-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 14.6.0 merge into master #7637
Conversation
* Prepare release * [bindgen] expose both SyncUser and app::User (#7634) * RCORE-2060 Enabling 'cancel_waits_on_nonfatal_error' does not cancel waits during location update while offline (#7528) * added tests using cancel_waits_on_nonfatal_error and fix operation during location update * Updated changelog and updated comments/debug statements * fix swift build and test and tsan errors * Added test to replicate swift autoopen feature * Fixed swift build issue * removed an unused function * Updates from review --------- Co-authored-by: Kenneth Geisshirt <[email protected]> Co-authored-by: Michael Wilkerson-Barker <[email protected]>
@@ -1,15 +1,13 @@ | |||
# NEXT RELEASE | |||
# 14.6.0 Release notes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should you add the section for next release now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't sure if it was added as part of this merge or in a separate PR. I can add it now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't know either. but at least now we update the changelog for the next release
Pull Request Test Coverage Report for Build michael.wilkersonbarker_1063Details
💛 - Coveralls |
Ideally, the commits with actual code changes should have their own commit in our mainline history, but it looks like they have been squashed together from the prepare branch. Since it is only a few changes, it will be manageable to figure out if we need to untangle them in the future. I think the more important thing is that the commit that was tagged as a release ends up on master, so please make sure this PR is not merged by squashing. Our release process documentation is terribly out of date, so I'm just grateful a release happened :) |
Should maybe delete the tag and replace it with one where the history isn't a mess? I don't really understand why the release process is so complicated. It seems to be designed to maximize the number of places where errors like this can be made. |
@tgoyne the release process sorely needs to be modernized and simplified now that we don't produce any build artifacts. |
What, How & Why?
Release 14.6.0 merge into master
Prepare release
[bindgen] expose both SyncUser and app::User ([bindgen] expose both SyncUser and app::User #7634)
RCORE-2060 Enabling 'cancel_waits_on_nonfatal_error' does not cancel waits during location update while offline (RCORE-2060 Enabling 'cancel_waits_on_nonfatal_error' does not cancel waits during location update while offline #7528)
added tests using cancel_waits_on_nonfatal_error and fix operation during location update
Updated changelog and updated comments/debug statements
fix swift build and test and tsan errors
Added test to replicate swift autoopen feature
Fixed swift build issue
removed an unused function
Updates from review