Update Example and Templates #6099
Conversation
.vscode/launch.json
Outdated
| @@ -4,6 +4,7 @@ | |||
| // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387 | |||
| "version": "0.2.0", | |||
| "configurations": [ | |||
|
|
|||
There was a problem hiding this comment.
Accidental line break?
There was a problem hiding this comment.
Accidental modification, yes
templates/expo-template/README.md
Outdated
There was a problem hiding this comment.
Should we mention anything about npm v9 here?
There was a problem hiding this comment.
Expo has already merged by PR, but I'm unsure when it will actually be released in the wild. I'll add a note that if they have issues they should upgrade npm
There was a problem hiding this comment.
I noticed that a README inside the react-native-template/template/ directory didn't exist before. Is this README meant to coexist with react-native-template/README.md?
There was a problem hiding this comment.
Yes, it's fine. React Native added a readme to their base template in version 72. I like to keep the templates as near to the React Native default. But now that you have pointed this out, I will added pieces of our template README into this one to explain sync
There was a problem hiding this comment.
That's fine, it's coming from the latest React Native
| export default App; | ||
|
|
||
| AppRegistry.registerComponent(appName, () => App); |
There was a problem hiding this comment.
Is there something importing App? Seemed to only be passed to AppRegistry before.
There was a problem hiding this comment.
The Jest test was importing the base app component. I realized it would be good to import something that works instead of having the template start with a broken test.
| "react-native-get-random-values": "^1.9.0", | ||
| "realm": "11.10.1" | ||
| "realm": "12.0.0" |
There was a problem hiding this comment.
Might have missed it, but did the contents of this file get moved somewhere else?
There was a problem hiding this comment.
Good catch. I generally just create a new react native project to upgrade the templates and copy the files in by hand. I had forgotten this one. Perhaps one day I'll actually get this automated in a sane way.
There was a problem hiding this comment.
I agree, it's often easier to just create a new project 👍
There was a problem hiding this comment.
Expo is the easiest. It actually can upgrade automatically.
* Fix small bug in error for auth hooks * Update dependencies * Update React Native and Expo in Templates
takameyer
force-pushed
the
andrew/update-templates
branch
from
beb3143
to
b78724f
Compare
What, How & Why?
This closes #5942
We should wait for this to be merged before releasing the expo template.
☑️ ToDos
Compatibilitylabel is updated or copied from previous entryCOMPATIBILITY.mdpackage.jsons (if updating internal packages)Breakinglabel has been applied or is not necessary