RJS-2771: Upgrade to Realm Core v14.4.0 #6569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraenhansen
approved these changes
Mar 21, 2024
elle-j
approved these changes
Mar 22, 2024
kraenhansen
reviewed
Mar 22, 2024
kraenhansen
reviewed
Mar 22, 2024
kraenhansen
reviewed
Mar 23, 2024
| @@ -239,6 +239,9 @@ function convertPrimToJsi(addon: JsiAddon, type: string, expr: string): string { | |||
| case "uint64_t": | |||
| return `bigIntFromU64(_env, ${expr})`; | |||
|
|
|||
| case "std::chrono::milliseconds": | |||
| return `bigIntFromU64(_env, std::chrono::milliseconds(${expr}).count())`; | |||
There was a problem hiding this comment.
Thinking more about this change. We should have been able to ignore this primitive all together, by simply not including it in the js_opt_in_spec.yml. Did bindgen fail if you didn't put this code in? If not - perhaps we should extend the "opt-in" feature to include primitives? What do you think @elle-j?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
This closes #6568, #6554, and #6558
☑️ ToDos
Compatibilitylabel is updated or copied from previous entryCOMPATIBILITY.mdpackage.jsons (if updating internal packages)Breakinglabel has been applied or is not necessary