Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "RJS-2717: Replaced lodash with lodash.isequal" #6730

Closed
wants to merge 1 commit into from
Closed

Revert "RJS-2717: Replaced lodash with lodash.isequal" #6730

wants to merge 1 commit into from

Conversation

kneth
Copy link
Contributor

@kneth kneth commented Jun 17, 2024 •
edited
Loading

Reverts #6633

It seems to break #6729

@cla-bot cla-bot bot added the cla: yes label Jun 17, 2024
elle-j
elle-j reviewed Jun 17, 2024
View reviewed changes
Copy link
Contributor

@elle-j elle-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the only change that should be needed (instead of reverting) is to:

  • Replace the 2 occurrences of:
import { isEqual } from "lodash.isequal";
  • With:
import isEqual from "lodash.isequal";

@kneth
Copy link
Contributor Author

kneth commented Jun 17, 2024

Closing as it can be solved: #6731 (similar to what @elle-j suggests above).

@kneth kneth closed this Jun 17, 2024
@kneth kneth deleted the revert-6633-main branch June 17, 2024 10:50
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@elle-j elle-j elle-j left review comments

Assignees

@kneth kneth

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kneth @elle-j